feat: monitoring for endpoints #24470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhpillai
commented
Aug 19, 2024
| @@ -72,6 +69,11 @@ def clear_stale_cohort(cohort_id: int, before_version: int) -> None: | |||
| @shared_task(ignore_result=True, max_retries=2) | |||
| def calculate_cohort_ch(cohort_id: int, pending_version: int, initiating_user_id: Optional[int] = None) -> None: | |||
| cohort: Cohort = Cohort.objects.get(pk=cohort_id) | |||
|
|
|||
| set_tag("feature", Feature.COHORT.value) | |||
There was a problem hiding this comment.
set_tag call needs to be in the same thread (celery task) for sentry scoping to work
webjunkie
approved these changes
Aug 20, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Don't have visibility on load to our endpoint. Can't detect spikes/falls in requests
Changes
Added monitoring to some endpoints for which we will want to have alerting setup.
Also setting the sentry tag for each of the requests so that we can categories errors/sentry issues according to the feature (have more context which parts of our stack are broken/cause users more issues)
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Tested the decorator is hit/doesn't error out locally